Re: [PATCH] HID: wacom: Simplify 'wacom_pl_irq'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 3 Aug 2015, Jason Gerecke wrote:

> Unlike other IRQ functions, 'wacom_pl_irq' uses the second element of
> the 'tool' array to store information about its single pen. This makes
> the function more difficult to understand (since it doesn't follow the
> general pattern of other IRQ functions) and prevents the possibility of
> refactoring how pen state is stored.
> 
> This patch rewrites 'wacom_pl_irq' to follow the usual IRQ conventions,
> including storing tool type in 'tool[0]' and implicitly tracking prox
> with the 'id[0]' variable.
> 
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>

Nice cleanup. Applied to for-4.3/wacom.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux