Hi,
Le 21/07/2015 10:19, Oliver Neukum a écrit :
On Mon, 2015-07-20 at 23:03 +0200, Yann Cantin wrote:
diff --git a/drivers/input/misc/ebeam.c b/drivers/input/misc/ebeam.c
new file mode 100644
index 0000000..79cac51
--- /dev/null
+++ b/drivers/input/misc/ebeam.c
+/* Electronics For Imaging, Inc */
+#define USB_VENDOR_ID_EFI 0x2650
You are defining these IDs twice. That is not good.
Is it okay to do this :
#if !defined(CONFIG_INPUT_EBEAM_USB)
#define USB_VENDOR_ID_EFI 0x2650
#...
#endif
so that the driver can also be build outside the kernel tree ?
thanks,
--
Yann Cantin
A4FEB47F
--
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html