* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> [150719 23:36]: > On Sun, Jul 19, 2015 at 11:05:07PM -0700, Tony Lindgren wrote: > > * Vignesh R <vigneshr@xxxxxx> [150719 21:51]: > > > On 7/18/2015 3:21 AM, Dmitry Torokhov wrote: > > > > > > > > I wonder if driver core should be responsible for clearing wake irq and > > > > also for clearing wakeup flag. > > > > > > > > > > AFAICU, wakeup flag is deleted when struct device is deleted, hence, > > > device_init_wakeup() call may not be required in .remove(). But, > > > dev_pm_clear_wake_irq() can be moved to driver core. > > > > Currently the lifecycle of struct wakeup_source is not necessarily > > the same as the lifecycle struct device. I believe net and usb drivers > > at least allocate it dynamically. > > I am not sure if I follow. I was wondering if we should clear the wakeup > IRQ setting on the driver unbinding. It does not mean that we'd be > deleting wakeup_source, just that we'll clear wakeup irq setting from > it. Yes you're right we can do that. I was mostly commenting on why we currently can't automate things further with devm. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
