Hi, On Wed, Jul 15, 2015 at 02:34:04PM -0700, Dmitry Torokhov wrote: > [...] > > if (np) { > > - ts->reset_gpio = of_get_named_gpio(np, "reset-gpios", 0); > > - if (ts->reset_gpio == -EPROBE_DEFER) > > - return ts->reset_gpio; > > - if (ts->reset_gpio < 0) { > > + ts->reset_gpio = devm_gpiod_get(&spi->dev, "reset", > > + GPIOD_OUT_HIGH); > > I think we should treat the gpio as optional and try to get the > descriptor event on non-OF boards. As I wrote in the cover letter, I suggest to change this once the Nokia N900 board code has been removed. At that point changing the board code API is much easier, since it won't affect multiple trees. > [...] -- Sebastian
Attachment:
signature.asc
Description: Digital signature