On Thu, Jun 25, 2015 at 03:25:10PM -0400, cpaul@xxxxxxxxxx wrote: > From: Stephen Chandler Paul <cpaul@xxxxxxxxxx> > > A big problem with the current i8042 debugging option is that it outputs > data going to and from the keyboard by default. As a result, many dmesg > logs uploaded by users will unintentionally contain sensitive information > such as their password, as such it's probably a good idea not to output > data coming from the keyboard unless specifically enabled by the user. > > Signed-off-by: Stephen Chandler Paul <cpaul@xxxxxxxxxx> > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > --- > Documentation/kernel-parameters.txt | 7 +++++++ > drivers/input/serio/i8042.c | 25 +++++++++++++++++++++---- > 2 files changed, 28 insertions(+), 4 deletions(-) > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > index ae44749..9e00234 100644 > --- a/Documentation/kernel-parameters.txt > +++ b/Documentation/kernel-parameters.txt > @@ -1304,6 +1304,13 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > <bus_id>,<clkrate> > > i8042.debug [HW] Toggle i8042 debug mode > + i8042.debug_kbd [HW] Enable printing of interrupt data from the KBD port > + As a side effect, this option will mask some of the > + interrupts sent back from the keyboard during the > + initialization of the KBD port on the i8042, if you > + need to see this, you will need to enable this > + option. Hmm, can we maybe use the bus notifier and react to BUS_NOTIFY_BOUND_DRIVER/BUS_NOTIFY_UNBIND_DRIVER to decide if we want to see keyboard data stream? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
