On Mon, Jun 22, 2015 at 01:01:18AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> Applied, thank you. > --- > drivers/input/keyboard/imx_keypad.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/imx_keypad.c b/drivers/input/keyboard/imx_keypad.c > index 2e855e6..d2ea863 100644 > --- a/drivers/input/keyboard/imx_keypad.c > +++ b/drivers/input/keyboard/imx_keypad.c > @@ -506,7 +506,9 @@ static int imx_keypad_probe(struct platform_device *pdev) > input_set_drvdata(input_dev, keypad); > > /* Ensure that the keypad will stay dormant until opened */ > - clk_prepare_enable(keypad->clk); > + error = clk_prepare_enable(keypad->clk); > + if (error) > + return error; > imx_keypad_inhibit(keypad); > clk_disable_unprepare(keypad->clk); > > -- > 1.9.1 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in
