Re: [PATCH v2] HID: support i2c write-read and large transfers in hid-cp2112

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 18, 2015 at 4:26 PM, Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
>
>> Mine is rev 1 !!!
>> Found also that in the datasheet chapter 12 reports the differences
>> between the two revisions.
>> In 12.1 it states that revision 1 does not implement repeated start. Perfect!
>> I will try to replace my device with a newer one.
>
> Can this be checked in the code?

You are right!
The code should check the revision and allow read-after-write for rev2
only. Or better, return error on rev1; we can expect any further
revision will implement it correctly.
Definitevy the revision can be retrieved by SW and used for the check.
Today rev# is already retrieved during probe() and printed. Should be
enough to keep it in a new field of the private date struct.

Thanks for the hint.
Antonio
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux