Dudley,
Just noticed a few spelling errors...
On Fri, Jun 12, 2015 at 02:56:32PM +0800, Dudley Du wrote:
> Change strings 'gen5' to 'pip' for all macros, varibales and functions when
sp: ^^^^^^^^^
> they are shared to be used in for gen5 and gen6 modules. The change of these
> strings is aimed to keep name definition much more clear and readable.
> TEST=test on Chromebook.
>
> Signed-off-by: Dudley Du <dudl@xxxxxxxxxxx>
> ---
> drivers/input/mouse/cyapa.c | 22 +-
> drivers/input/mouse/cyapa.h | 133 ++++-
> drivers/input/mouse/cyapa_gen3.c | 2 +-
> drivers/input/mouse/cyapa_gen5.c | 1092 ++++++++++++++++++--------------------
> 4 files changed, 661 insertions(+), 588 deletions(-)
>
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index efe1484..e7d4226 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -6,7 +6,7 @@
> * Daniel Kurtz <djkurtz@xxxxxxxxxxxx>
> * Benson Leung <bleung@xxxxxxxxxxxx>
> *
[...]
> /* Size of packet not including output report register address */
> __le16 length;
> @@ -352,7 +298,7 @@ struct gen5_app_cmd_head {
> u8 parameter_data[0]; /* Parameter data variable based on cmd_code */
> } __packed;
>
> -/* Application get/set parameter command data structure */
> +/* Applicaton get/set parameter command data structure */
sp: ^^^^^^^^^^
> struct gen5_app_set_parameter_data {
> u8 parameter_id;
> u8 parameter_size;
> @@ -369,30 +315,26 @@ struct gen5_retrieve_panel_scan_data {
> u8 data_id;
> } __packed;
[...]
> + pip->irq_cmd_buf, length))) {
> /*
> - * Work around the Gen5 V1 firmware
> - * that does not assert interrupt signalling
> - * that command response is ready if user
> - * keeps touching the trackpad while command
> - * is sent to the device.
> + * Cover the Gen5 V1 firmware issue.
> + * The issue is there is no interrut will be
sp: ^^^^^^^^
> + * asserted to notityf host to read a command
sp: ^^^^^^^
> + * data out when always has finger touch on
> + * trackpad during the command is issued to
> + * trackad device.
sp: ^^^^^^^
> + * This issue has the scenario is that,
> + * user always has his fingers touched on
> + * trackpad device when booting/rebooting
> + * their chrome book.
> */
The wording in the above section could be improved as well.
> length = 0;
> - if (gen5_pip->resp_len)
> - length = *gen5_pip->resp_len;
> + if (pip->resp_len)
> + length = *pip->resp_len;
> cyapa_empty_pip_output_data(cyapa,
> - gen5_pip->resp_data,
[...]
--
- Jeremiah Mahler
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
