On Jun 10 2015 or thereabouts, Bastien Nocera wrote: > On Tue, 2015-06-09 at 11:52 -0700, Dmitry Torokhov wrote: > > input_mt_init_slots() will do that for us. > > I'm guessing you know what you're doing here, but I couldn't find where > the EV_SYN bit would have been set in the input_mt_init_slots() call > chain. input_register_device() sets EV_SYN bit for us (it is a mandatory field for input). > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > --- > > drivers/input/touchscreen/goodix.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/input/touchscreen/goodix.c > > b/drivers/input/touchscreen/goodix.c > > index 73ade35..b4d12e2 100644 > > --- a/drivers/input/touchscreen/goodix.c > > +++ b/drivers/input/touchscreen/goodix.c > > @@ -301,10 +301,6 @@ static int goodix_request_input_dev(struct > > goodix_ts_data *ts, u16 version, > > return -ENOMEM; > > } > > > > - ts->input_dev->evbit[0] = BIT_MASK(EV_SYN) | > > - BIT_MASK(EV_KEY) | > > - BIT_MASK(EV_ABS); > > - Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Cheers, Benjamin > > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_X, > > 0, ts->abs_x_max, 0, 0); > > input_set_abs_params(ts->input_dev, ABS_MT_POSITION_Y, > > -- > > 2.2.0.rc0.207.ga3a616c > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
