On 06/09/2015 07:12 PM, Dmitry Torokhov wrote:
> On Tue, Jun 09, 2015 at 07:25:42AM +0200, Daniel Mack wrote:
>> Use the .brightness_set_sync callback, so you don't have to dance around
>> with the workers at all.
>
> Umm, how will it help? You still can't sleep in set_brightness().
> brightness_set_sync() just says that the driver guarantees that the LED
> state will be set (or error returned) when the function returns.
Hmm, right. I was mislead by this comment in include/linux/leds.h:
/*
* Set LED brightness level immediately - it can block the caller for
* the time required for accessing a LED device register.
*/
But I in fact don't see any wrapper logic that magically uses a worker
when called from interrupt context.
Thanks for the heads-up!
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
