On Tue, Jun 09, 2015 at 01:26:34PM +0200, Pavel Machek wrote: > On Tue 2015-06-09 13:12:42, Pavel Machek wrote: > > On Tue 2015-06-09 12:54:21, Pavel Machek wrote: > > > Hi! > > > > > > > I finally was able to spend some time looking over Samuel's patch set > > > > switching input LEDs from custom implementation over to standard LED class > > > > devices and I think this is the shape I am reasonably happy with. The > > > > changes: > > > > > > Thanks! > > > > > > > Please take a look and see if you see any holes. > > > > > > Tested on thinkpad t40p. Started X, but then I went to text console > > > for testing. > > > > > > 1) input4::caps-lock -- default trigger was not set, so caps lock did > > > not control the LED. That's bug, right? > > > > Strange, on next reboot default triggers were set. > > Even more strange... setting brightness to zero resets the trigger, > setting it to one does not. Oh well, that is problem with other LEDs, > too. That is current led core behavior. See drivers/led/led-class.c::brightness_store(): if (state == LED_OFF) led_trigger_remove(led_cdev); led_set_brightness(led_cdev, state); Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
