Hi Pavel, On Tue, Jun 09, 2015 at 06:18:18PM +0200, Pavel Machek wrote: > Hi! > > > > I finally was able to spend some time looking over Samuel's patch set > > > switching input LEDs from custom implementation over to standard LED class > > > devices and I think this is the shape I am reasonably happy with. The > > > changes: > > > > Thanks! > > > > > Please take a look and see if you see any holes. > > > > Tested on thinkpad t40p. Started X, but then I went to text console > > for testing. > > > > 1) input4::caps-lock -- default trigger was not set, so caps lock did > > not control the LED. That's bug, right? > > max_brightness for caps-lock led is 255. I believe that should be 1, > as keyboard LEDs can not do PWM. Yes, you are right, I'll change max_brightness to 1 in the next revision. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
