On 6/4/2015 7:18 AM, Benjamin Tissoires wrote: > Hi Jason, > > On Jun 03 2015 or thereabouts, Jason Gerecke wrote: >> I've recently got my hands on a device which has an I2C sensor that sends >> both pen and touch reports from a single interface. To userspace, it shows >> up as a single input device which blends both the report types (e.g. it has >> ABS_PRESSURE for the pen, and ABS_MT_POSITION_X for the touch). This patch >> set modifies the driver to be able to handle devices which place both pen >> and touch on a the same interface. It does this by treating the pen, touch, >> and pad (which was already special-cased) independently. If a device has >> the appropriate device_type, one or more of pen/touch/pad input devices >> will be created, initialized, and used to send data to userspace. >> >> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx> > > This all seems sensible. I gave a quick look yesterday and could not > found any obvious problem, but I'd like to review it more thoroughly > before giving my rev-by (and do a little bit of testing too). > > I don't believe there will be any problems for the series, besides the > Bamboo PAD. Have you tested on this? > > Cheers, > Benjamin > I don't have a Bamboo PAD to test with, but carefully looking at each interface's HID descriptor makes me think you may be right. The debug interface in particular uses a WACOM_VENDORDEFINED_PEN application collection and will be marked as WACOM_DEVICETYPE_PEN instead of WACOM_DEVICETYPE_TOUCH. The smallest fix that should do the trick would be to just swap the device_type in 'wacom_setup_device_quirks'. Alternatively, we could only allow the debug interface to be probed, set the touch device type flag (in addition to the automatically-set pen flag), and extend the IRQ function to explicitly handle pen events. The alternative is a bit more work (and we'd need somebody with a device to test it...) but I think might make the codepath for the Bamboo PAD a bit easier to follow. -- Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... >> >> Jason Gerecke (5): >> HID: wacom: Simplify 'wacom_update_name' >> HID: wacom: Treat features->device_type values as flags >> HID: wacom: Introduce a new WACOM_DEVICETYPE_PAD device_type >> HID: wacom: Split apart 'wacom_setup_pentouch_input_capabilites' >> HID: wacom: Introduce new 'touch_input' device >> >> drivers/hid/wacom.h | 4 +- >> drivers/hid/wacom_sys.c | 194 +++++++++++++++---------- >> drivers/hid/wacom_wac.c | 379 ++++++++++++++++++++++++++---------------------- >> drivers/hid/wacom_wac.h | 15 +- >> 4 files changed, 332 insertions(+), 260 deletions(-) >> >> -- >> 2.4.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
