Hi All, This is the 6th attempt for a Logitech mouse M560 hid driver. On the basis of the feedback received, I made some changes in the code: v6: - hid-core.c: rename extract() to hid_field_extract() and make it linkage external - hid-logitech-hidpp.c: use hid_field_extract() instead of hidpp_extract() as per Jiri request. - update the error message in m560_raw_event() to be more specific v5: - simplified the checks inside m560_raw_event() - rearranged the return codes in m560_raw_event(): 0 in case the frame is not corrected, 1 if the data are correct. This is the behavior observed in other drivers, even if the returned values may vary. The patch is against v4.1-rc5. Special thanks to Antonio and Benjamin for their support and testing. BR G.Baroncelli -- gpg <at> keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html