On May 21 2015 or thereabouts, Jason Gerecke wrote:
> Retrying on -EPIPE makes very little sense since this typically indicates
> a problem that will not just disappear on its own. For instance, the USB
> documentation states that it will be sent if the endpoint is stalled or
> the device has disconnected. Instead, we should retry if -EAGAIN is
> received since this indicates a temporary error condition such as a busy
> bus.
>
> In addition to adjusting the conditions we retry under, we also log an
> error on failure so that we can be aware of what's going on.
>
> Signed-off-by: Jason Gerecke <jason.gerecke@xxxxxxxxx>
> ---
The series is:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
Thanks for the respin Jason!
Cheers,
Benjamin
> Changed in v2:
> - Renamed from "HID: wacom: Allow wacom_{get,set}_report to retry on -EAGAIN"
> - Changed retry conditions so that we no longer retry on -EPIPE
> - Use 'hid_err' instead of 'dev_err'
>
> drivers/hid/wacom_sys.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 7abf52c..109312f 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -35,7 +35,11 @@ static int wacom_get_report(struct hid_device *hdev, u8 type, u8 *buf,
> do {
> retval = hid_hw_raw_request(hdev, buf[0], buf, size, type,
> HID_REQ_GET_REPORT);
> - } while ((retval == -ETIMEDOUT || retval == -EPIPE) && --retries);
> + } while ((retval == -ETIMEDOUT || retval == -EAGAIN) && --retries);
> +
> + if (retval < 0)
> + hid_err(hdev, "wacom_get_report: ran out of retries "
> + "(last error = %d)\n", retval);
>
> return retval;
> }
> @@ -48,7 +52,11 @@ static int wacom_set_report(struct hid_device *hdev, u8 type, u8 *buf,
> do {
> retval = hid_hw_raw_request(hdev, buf[0], buf, size, type,
> HID_REQ_SET_REPORT);
> - } while ((retval == -ETIMEDOUT || retval == -EPIPE) && --retries);
> + } while ((retval == -ETIMEDOUT || retval == -EAGAIN) && --retries);
> +
> + if (retval < 0)
> + hid_err(hdev, "wacom_set_report: ran out of retries "
> + "(last error = %d)\n", retval);
>
> return retval;
> }
> --
> 2.4.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
