On Tue, May 19, 2015 at 11:38:28AM +0100, Lee Jones wrote: > On Sun, 17 May 2015, Dmitry Eremin-Solenikov wrote: > > +static void locomo_mask_irq(struct irq_data *d) > > +{ > > + struct locomo *ldev = irq_data_get_irq_chip_data(d); > > + unsigned int mask = 0x0010 << d->hwirq; > > This also needs defining. > > Why not > BIT(d->hwirq + 1) I think your maths is off... 0x0010 << d->hwirq != BIT(d->hwirq + 1) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html