Hi Frank. On Wednesday, May 13, 2015 01:27:39 PM Zhi Li wrote: > On Wed, May 13, 2015 at 11:40 AM, Dmitry Torokhov > > <dmitry.torokhov@xxxxxxxxx> wrote: > > Hi Frank, > > > > > >> + pdata->ioaddr = of_iomap(np, 0); > >> + if (IS_ERR(pdata->ioaddr)) > >> + return PTR_ERR(pdata->ioaddr); > > > > Umm, you are still leaking it on error path. Can you try doing: > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > pdata->ioaddr = devm_ioremap_resource(&pdev->dev, res); > > if (IS_ERR(pdata->ioaddr)) > > > > return PTR_ERR(pdata->ioaddr); > > Thank you for comments. > but I don't use of_iomap here because the resource is shared with the > other device. > > SNVS included a rtc, a power off, ON/OFF key. > If I use platform_get_resource and devm_ioremap_resource, rtc driver > fail to probe. > > best regards > Frank Li > The fact that you cannot use of_iomap() seems a clear warning of unsafe access. Since it is a shared resource, which you are writing to as well as reading, perhaps you should set it up for safe access using the regmap API like the GPR registers. /include/linux/mfd/syscon/imx6q-iomuxc-gpr.h -- ~Joshua Clayton -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
