Hi Frank, looks like a typo in your subject line. keyboard? > Frank.Li@xxxxxxxxxxxxx hat am 13. Mai 2015 um 16:47 geschrieben: > > [...] > diff --git a/drivers/input/keyboard/snvs_pwrkey.c > b/drivers/input/keyboard/snvs_pwrkey.c > new file mode 100644 > index 0000000..e4c2de3 > --- /dev/null > +++ b/drivers/input/keyboard/snvs_pwrkey.c > @@ -0,0 +1,239 @@ > +/* a small driver description here would be nice. > + * Copyright (C) 2015 Freescale Semiconductor, Inc. All Rights Reserved. > + * > + * The code contained herein is licensed under the GNU General Public > + * License. You may obtain a copy of the GNU General Public License > + * Version 2 or later at the following locations: > + * > + * http://www.opensource.org/licenses/gpl-license.html > + * http://www.gnu.org/copyleft/gpl.html > + */ > + > [...] > +static int imx_snvs_pwrkey_probe(struct platform_device *pdev) > +{ > [...] > + > + pdata->wakeup = !!of_get_property(np, "linux,wakeup", NULL); of_property_read_bool() ? > + > [...] > + > + ret = input_register_device(input); > + if (ret < 0) { > + dev_err(&pdev->dev, "failed to register input device\n"); > + input_free_device(input); input_free_device() shouldn't be necessary since you are using devm_input_allocate_device(). Thanks Best regards Stefan -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html