2015-05-12 22:24 GMT+03:00 Wolfram Sang <wsa@xxxxxxxxxxxxx>: > On Tue, Apr 28, 2015 at 02:55:47AM +0300, Dmitry Eremin-Solenikov wrote: >> LoCoMo chip contains a tiny i2c controller destined to control >> M62332 DAC. Provide a separate I2C driver for this cell. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> > > Thanks for the submission! > >> +#include <linux/kernel.h> >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/regmap.h> >> +#include <linux/slab.h> >> +#include <linux/mfd/locomo.h> >> + >> +#include <linux/i2c.h> >> +#include <linux/i2c-algo-bit.h> > > To avoid duplicates, I prefer the includes to be sorted. No need to > resend because of that, though. > > Kudos for brushing up old code! Do you want the drivers go via the > subsystem trees? Or is there a dependency so it should go in via some > other tree in one go? There is a header dependency -- <linux/mfd/locomo.h> is a new header. I'd prefer for these patches to go in via one of MFD, arm-soc or ARM trees as a whole series (if that would be ok with respective maintainers). -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
