Re: [PATCH] Input: smtpe-ts: Use msecs_to_jiffies() instead of HZ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, May 07, 2015 at 01:59:28 AM, Dmitry Torokhov wrote:
[...]

Hi!

> > Maybe I'm fixing two bugs here ? The problem I really had is that with
> > kernel HZ set to 250 and the original code, the work was scheduled and
> > executed too quickly, so my touchscreen was bouncing between pendown and
> > penup events back and forth, without doing any usaful work.
> > 
> > I tried changing the code to HZ/5 instead of HZ/50 and that fixes my
> > issue as well.
> > 
> > My impression is that using msec_to_jiffies() is clearer especially
> > if the code is to represent a constant delay.
> 
> It is indeed clearer and I would not mind such conversion, we just need
> to adjust the comment why we do that.
> 
> > But maybe I should then
> > document why I changed the duration (because the original one was too
> > short) ?
> 
> Please make a separate patch for that with separate justification.
> 
> Thanks!

Roger, will do, thank you!

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux