On Sun, 2015-04-05 at 16:56 -0700, Dmitry Torokhov wrote: > On Sun, Apr 05, 2015 at 06:04:24PM +0200, Bastien Nocera wrote: > > On Sun, 2015-04-05 at 00:08 +0300, Priit Laes wrote: > > > This patch implements GT801x2 touchscreen support. > > > Unfortunately, there is a big difference between GT801 and GT9xx > > > series > > > chips, therefore some advice is needed on how to proceed. > > > > > > Differences between GT801x2 and GT9xx series: > > > > > > 1. I2C registers: 1 byte (GT801x2) vs 2 bytes (GT9xx) > > > 2. Different configuration layout and version info > > > 3. Different touch report protocol > > > > That doesn't seem like an awful lot of differences. Approximately > > 80 > > line changes for 500 lines of driver code. You could add an enum > > for > > the 8xx and 9xx types near the top, add that as driver data in the > > match arrays (both the ACPI and OF ones). Then have if statements > > choose the correct init, read and report functions. > > > > I would think that that would grow the driver by a further 50 > > lines, > > which would certainly be acceptable. > > > > Don't forget to add your name to the copyright header mentioning > > you're the author for the 8xx support :) > > > > > Signed-off-by: Priit Laes <plaes@xxxxxxxxx> > > > > There's really no need to sign it off if you know it's not going > > to be > > accepted upstream ;) > > Actually I think it is still useful: that means that somebody else > can > use the patch as a base for their work without any concerns even if > original author did not see it through upstream acceptance for some > reason. Right, fair enough. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
