Re: [PATCH v2 2/2] Support-Alps-Touchpad-SS4-device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 03/28/2015 05:36 AM, Dmitry Torokhov wrote:
On Fri, Mar 27, 2015 at 09:25:09AM +0100, Hans de Goede wrote:
Hi,

On 27-03-15 21:29, Masaki Ota wrote:
From: Masaki Ota <masaki.ota@xxxxxxxxxxx>
-Support SS4 device
-SS4 device supports 4Finger and real multi-touch.

Signed-off-by: Masaki Ota <masaki.ota@xxxxxxxxxxx>

Thanks looks good now:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

One remark though, you enable: BTN_TOOL_QUINTTAP for v7 touchpads
in the alps_set_abs_params_v7_v8 changes. This is the right thing
to do as v7 can indeed report 5 fingers being down, something which I
missed when I added support for it. But it would be good to have
a small note about this in the commit message.

Dmitry, can you amend the commit message for this when merging this?

How about we simply split it out, like below?


Yes that would be even better :)

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux