On Fri, Mar 27, 2015 at 01:17:20AM +0100, Jiri Kosina wrote: > On Fri, 27 Mar 2015, Peter Hutterer wrote: > > > Spell out what this property means to userspace. If the property is set, all > > directional axes must be accelerometer axes, any other axes are left as-is. > > This allows an accelerometer device to e.g. have an ABS_WHEEL. > > > > It is not permitted to mix normal directional axes and accelerometer axes on > > the same device node. > > > > Signed-off-by: Peter Hutterer <peter.hutterer@xxxxxxxxx> > > --- > > I think this is the most sensible definition of what to expect when this > > property is set on a device. > > First, I am quilty here. I've let INPUT_PROP_ACCELEROMETER slip through my > tree without Dmitry's Ack, which is what I normally require for everything > touching input.h. Mea culpa maxima, I missed it, sorry for that. > > This makes sense to me though. So > > Acked-by: Jiri Kosina <jkosina@xxxxxxx> > > but let's see what Dmitry has to say. > > Good thing is that this went only into 4.0-rc1, so if the whole > INPUT_PROP_ACCELEROMETER turns out to be absolute no-go for some reason, > we can still revert it. No, I think that's fine. In the past I was hesitant of defining device types, but at least for accelerometers, given that we state that we will not be mixing them with regular directional axes, that should be fine. I will apply this. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
