On Sat, Mar 21, 2015 at 9:24 AM, Ramiro Morales <cramm0@xxxxxxxxx> wrote: > On Thu, Mar 19, 2015 at 7:15 PM, Benjamin Tissoires > <benjamin.tissoires@xxxxxxxxx> wrote: >> Then I am even more surprised that you need to quirk a late 2014 >> haswell refresh. >> >> Can you post your dmesg when booting the synaptics branch so that we >> can check if the FW has the correct values stored or if we really need >> to quirk it? > > On Thu, Mar 19, 2015 at 7:15 PM, Benjamin Tissoires > <benjamin.tissoires@xxxxxxxxx> wrote: >> Then I am even more surprised that you need to quirk a late 2014 >> haswell refresh. > > Actually the laptop manufacturing date is Nov '13, I bought it on May. > > This patch is almost a year late because I had a false start > submitting fixes through the Ubuntu BTS[1] only to discover that a > clashing quirk for the E540 got added upstream about the same time. > The ability to include the board ID in the quirk table logic added by > this branch provides a way out. > >> Can you post your dmesg when booting the synaptics branch so that we >> can check if the FW has the correct values stored or if we really need >> to quirk it? > > Here it is: > > https://dl.dropboxusercontent.com/u/5403630/dmesg_thinkpad_e440_synaptics_8f004f3f.txt Thanks for all these information. So indeed, your patch is entirely valid and is: Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> Cheers, Benjamin > > Regards, > > > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1395243 > [2] https://git.kernel.org/cgit/linux/kernel/git/dtor/input.git/commit/?id=bce4f9e764c36bc35dd5c9cf9e057c09f422397d > > -- > Ramiro Morales > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
