Hi,
On Thu, Mar 12, 2015 at 04:18:03PM +0100, Philipp Zabel wrote:
> Hi Markus,
>
> Am Donnerstag, den 12.03.2015, 15:50 +0100 schrieb Markus Pargmann:
> > The trigger settings for a given irq are parsed from DT. Defining them
> > as flag for devm_request_threaded_irq() overwrites these settings. This
> > results in wrong trigger settings for boards which have different irq
> > triggers.
> >
> > Signed-off-by: Markus Pargmann <mpa@xxxxxxxxxxxxxx>
> > ---
> > drivers/input/touchscreen/egalax_ts.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
> > index 4c56299284ef..b0e6448b743c 100644
> > --- a/drivers/input/touchscreen/egalax_ts.c
> > +++ b/drivers/input/touchscreen/egalax_ts.c
> > @@ -218,7 +218,7 @@ static int egalax_ts_probe(struct i2c_client *client,
> >
> > error = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> > egalax_ts_interrupt,
> > - IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> > + IRQF_ONESHOT,
> > "egalax_ts", ts);
> > if (error < 0) {
> > dev_err(&client->dev, "Failed to register interrupt\n");
>
> There are three device trees which have eeti,egalax_ts nodes with
> interrupt flags 0:
>
> arch/arm/boot/dts/imx53-tx53-x13x.dts (twice),
> arch/arm/boot/dts/imx6dl-tx6u-811x.dts, and
> arch/arm/boot/dts/imx6q-tx6q-1110.dts.
>
> Will these still work after this change?
Oh right, thanks, these should be fixed as well.
Best regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: Digital signature
