On Thu, Feb 26, 2015, at 03:18, Darren Hart wrote: > On Fri, Feb 20, 2015 at 03:44:10PM +0100, Bastien Nocera wrote: > > Rather than checking on each suspend and resume whether the laptop > > has an adaptive keyboard, check when the driver is initialised. > > Bastien, am I awaiting another version of this from you to address > comments from > Henrique? > > Henrique, when you're satisfied, please provide a Reviewed-by for the > series. I usually provide a signed-off-by, as I am the thinkpad-acpi driver maintainer... reviewed-by is implied in that case. Let's wait a little bit to see if we get a reply on the keycodes. That said, Bastien, feel free to send the next version at any time. I won't object to the initial keymap being full of KEY_RESERVED/KEY_UNKNOWN and receiving incremental patches later. It might even help merging, as you could merge the new keycodes in a smaller patchset through the input tree, later. But I really want to see a patch added to the series that updates the driver documentation before the series gets merged. It should document any new sysfs entries, and also the relevant HKEY events related to the adaptative keyboard, as well as the new keymap. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
