Hi Antonio, > These annotations about the history of a patch are usually added > after the '---' marker right before sending the patch, not in the commit > message. > > They are useful for reviewers, but not really interesting anymore after > the code is validated and merged. > > In the subject you can mark a v2 like [PATCHv2], the prefix will be > stripped by git am, do not put the version of the patch in the short > commit message itself. Thanks, communities differ wrt these, I'm not often around the kernel. > Moreover, a following cleanup patch could make this __u8 *buf which > would be the correct type. > > Another follow-up patch could indeed use SIXAXIS_REPORT_0xF2_SIZE and > also define SIXAXIS_REPORT_0xF5_SIZE. > > I can do these latter if you want. Yes, please do. You have more experience around these parts and can get it done faster. > Maybe you can add a "goto out" here and skip the other steps if a > previous one fails. Or is some slack actually required to support > compatible controllers? They all succeed on mine, so will add the goto. - Lauri -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
