Hi Dmitry, On Wed, Feb 4, 2015 at 9:24 AM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > On Wed, Jan 14, 2015 at 04:54:14PM +0800, Sonic Zhang wrote: >> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx> >> >> - use readw and writew to access rotary MMRs >> - remap rotary register physical address into kernel space in probe >> >> v2-changes: >> - replace kzalloc with devm_kzalloc >> - replace request_irq with devm_request_irq >> - remove memory free and irq free from the device remove function > > This needs to be split in 2 as these are 2 separate changes - using > generic IO accessors and converting to use managed resources. > > By the way, you can also use devm_input_allocate_device() and not need > free/unregister it. > OK. I will separate this patch and send out new ones. Thanks, Sonic -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html