On Monday 02 February 2015 06:34:08 Dmitry Torokhov wrote: > On Sat, Jan 17, 2015 at 11:26:50AM +0100, Pali Rohár wrote: > > On Wednesday 14 January 2015 23:55:53 Dmitry Torokhov wrote: > > > On some Dell Latitudes we fail to identify presence of > > > trackstick unless we reset the device. The issue is quite > > > benign as we do perform reset in alps_init(), so the > > > trackstick ends up working, but mouse name reported to > > > userspace is not accurate. > > > > > > In order to fix the issue while avoiding the additional > > > lengthy reset we move the resrt to alps_detect() and keep > > > the discovered state to be used later in alps_init(). > > > > > > Reported-by: Pali Rohár <pali.rohar@xxxxxxxxx> > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > > > > This patch is not enough. ALPS_DUALPOINT flag can be removed > > also in function alps_hw_init_rushmore_v3() which is called > > from alps_init() but not from alps_detect(). So this patch > > does not have to set correct name in alps_detect() based on > > ALPS_DUALPOINT flag. My original patch set name in > > alps_init() after hw_init() which handled also this > > problem... > > Hmm, I think if we are still seeing these after somewhat > recent addition of full reset in detect procedure we need to > fix our detection instead of tweaking capabilities after > initialization phase fails. So I will just remove that bit > from alps_hw_init_rushmore_v3(). FWIW I did a quick search on > Google and do not seem to find dmesgs with message > "trackstick E7 report failed". > > Thanks. Ok, in this case kernel just register redundant input device which does not send any events to userspace. -- Pali Rohár pali.rohar@xxxxxxxxx
Attachment:
signature.asc
Description: This is a digitally signed message part.
