On Fri, Jan 30, 2015 at 02:16:00PM -0800, Dmitry Torokhov wrote: > On Fri, Jan 30, 2015 at 11:12:53AM -0800, Bryan Wu wrote: > > On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote: > > > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > > > <o.schinagl@xxxxxxxxxxxxx> wrote: > > > > > >> From: Olliver Schinagl <oliver@xxxxxxxxxxx> > > >> > > >> The gpio binding document says that new code should always use named > > >> gpios. Patch 40b73183 added support to parse a list of gpios from child > > >> nodes, but does not make it possible to use named gpios. This patch adds > > >> the con_id property and implements it is done in gpiolib.c, where the > > >> old-style of using unnamed gpios still works. > > >> > > >> Signed-off-by: Olliver Schinagl <oliver@xxxxxxxxxxx> > > >> --- > > >> drivers/gpio/devres.c | 18 +++++++++++++++++- > > >> drivers/input/keyboard/gpio_keys_polled.c | 2 +- > > >> drivers/leds/leds-gpio.c | 2 +- > > >> include/linux/gpio/consumer.h | 1 + > > > > > > Alexandre: does this match your vision of how it should work, i.e. ACK? > > > > > > Bryan/Dmitry: can you ACK the oneliners in your subsystems? > > > > Sure, please take my Ack > > Acked-by: Bryan Wu <cooloney@xxxxxxxxx> > > Mine as well: > > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> Forgot to mention: the ack is for this patch only; the patch #4 is NAKed because: 1. The logic of handling old and new name AFAICS is broken and 2. gpio_keys_polled-gpios as name is plain ugly. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
