HI Al, On Fri, Jan 30, 2015 at 4:15 AM, Alistair Leslie-Hughes <leslie_alistair@xxxxxxxxxxx> wrote: > Hi, > > On USB Microsoft keyboards, it creates a joystick device (/dev/input/js0). > This appears to be affect applications like WINE when attempting to play > certain games. > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=52841 > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=37982 > > I can confirm that, at least, the /dev/input/js0 is no longer created on > boot. This might not be the correct way to do this but hopefully I'm not > completely off track. > > And advice/comments would be good. Hmm, it looks like your patch fixes 2 things: - it adds support for 4 "new" microsoft keyboards - it adds an automatic ignore in some cases for the keyboards. I am not confident in having a patch which does these 2 things because we won't be able to bisect the change if it breaks someone else device. Also, it's easier for us to review the patch if you inline it in your mail. Please use git send-email on your next submission. Please resubmit your patch after having split it in 2. One for the 4 new keyboards (it should be applied quickly), and one other with only the hid_ignore hunk. Also, pleas make tests if the hid_ignore hunk is really necessary, because my nose told me that his one will break other supported devices. Cheers, Benjamin PS: please also CC Jiri for your next submission if you want your patches to be included. > > Best Regards > Alistair Leslie-Hughes -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
