On Fri, 23 Jan 2015, Simon Wörner wrote:
> From: Simon Wörner <mail@xxxxxxxxxxxxxxxx>
>
Changelog is missing here.
> Signed-off-by: Simon Wörner <mail@xxxxxxxxxxxxxxxx>
> ---
> drivers/hid/Kconfig | 6 ++
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-synaptics.c | 190 ++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 198 insertions(+)
> create mode 100644 drivers/hid/hid-synaptics.c
[ ... snip ... ]
> +static int synaptics_probe(struct hid_device *hdev,
> + const struct hid_device_id *id)
> +{
> + int ret;
> +
> + ret = hid_parse(hdev);
> + if (ret) {
> + hid_err(hdev, "parse failed\n");
> + goto err_free;
> + }
> +
> + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> + if (ret) {
> + hid_err(hdev, "hw start failed\n");
> + goto err_free;
> + }
> +
> + if (ret < 0)
> + goto err_stop;
> +
> + return 0;
> +err_stop:
> + hid_hw_stop(hdev);
> +err_free:
Any particular reason you call this label err_free?
Otherwise it loosk good. Please resend with these two minor things
clarified/fixed, and I'll apply it.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
