Dudley, On Thu, Jan 22, 2015 at 09:57:42AM +0000, Dudley Du wrote: > > -----Original Message----- > > From: Jeremiah Mahler [mailto:jmmahler@xxxxxxxxx] > > Sent: 2015?1?22? 17:31 > > To: Dudley Du [...] > > > struct gen5_bl_metadata_row_params { > > > __le16 size; > > > -__le16 maximun_size; > > > +__le16 maximum_size; > > I don't think sparse cares about variable names. > > Be sure to note these changes in your log. > > This is a spell mistake issue, not sparse warning issue. > Thanks. > That is fine but just be sure to note that in the log. I get suspicious when there are changes that aren't mentioned in the log. [...] > > > + > > > +if (app_integrity->flash_array_id != 0x00 || > > > + get_unaligned_be16(&app_integrity->row_number) != 0x01ff) { > > I could be wrong but it looks there are a lot of changes un-related to > > the sparse warning. I am not opposed to this per se but they should be > > noted in the log message. > > Understood. > Indeed, excepted the spell error, the purpose of the changes are aimed to fix the warning issue. > Do I need to add the log message and re-submit the patch or in other method ot change this? > Thanks. > Once I was able to reproduce the error there were quite a few. So this number of changes seems reasonable. The fix is already in -next so I don't think it is a big enough problem to worry about. -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
