> -----Original Message----- > From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx] > Sent: 2015?1?19? 8:27 > To: Dudley Du > Cc: jmmahler@xxxxxxxxx; rydberg@xxxxxxxxxxx; bleung@xxxxxxxxxx; > linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v18 09/12] input: cyapa: add gen5 trackpad device firmware > update function support > > On Fri, Jan 16, 2015 at 02:34:12PM +0800, Dudley Du wrote: > > +/* APP_INTEGRITY row is always the last row block, > > + * and the row id must be 0x01ff */ > > +row_num = get_unaligned_be16( > > +&image->records[flash_records_count - 1].row_number); > > +if (image->records[flash_records_count - 1].flash_array_id != 0x00 && > > +row_num != 0x01ff) { > > By the way, shouldn't this be "or" and not "and"? It should or, thanks for the correction. > > > +dev_err(dev, "%s: invalid app_integrity data.\n", __func__); > > +return -EINVAL; > > +} > > Thanks. > > -- > Dmitry This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
