Re: [PATCH 1/3] input: goodix: Add device tree support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Look at include/linux/of.h

#ifdef CONFIG_OF
 ...
#define of_match_ptr(_ptr)	(_ptr)
 ...
#else /* CONFIG_OF */
 ...
#define of_match_ptr(_ptr)	NULL
 ...
#endif /* CONFIG_OF */

So it would be compiled. Similarly in other touchscreen drivers.
But Kconfig should be fixed to enable CONFIG_OF. Will be fixed in v2.

2015-01-17 23:38 GMT+03:00, Bastien Nocera <hadess@xxxxxxxxxx>:
> On Sat, 2015-01-17 at 17:36 +0300, Aleksei Mamlin wrote:
>> Signed-off-by: Aleksei Mamlin <mamlinav@xxxxxxxxx>
>> ---
>>  drivers/input/touchscreen/goodix.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/input/touchscreen/goodix.c
>> b/drivers/input/touchscreen/goodix.c
>> index ca19668..603d2ae 100644
>> --- a/drivers/input/touchscreen/goodix.c
>> +++ b/drivers/input/touchscreen/goodix.c
>> @@ -23,6 +23,7 @@
>>  #include <linux/irq.h>
>>  #include <linux/interrupt.h>
>>  #include <linux/slab.h>
>> +#include <linux/of.h>
>>  #include <asm/unaligned.h>
>>
>>  struct goodix_ts_data {
>> @@ -378,6 +379,14 @@ static const struct acpi_device_id
>> goodix_acpi_match[] = {
>>  };
>>  MODULE_DEVICE_TABLE(acpi, goodix_acpi_match);
>>
>> +#ifdef CONFIG_OF
>> +static struct of_device_id goodix_of_match[] = {
>> +	{ .compatible = "goodix,gt9xx" },
>> +	{ }
>> +};
>> +MODULE_DEVICE_TABLE(of, goodix_of_match);
>> +#endif
>> +
>>  static struct i2c_driver goodix_ts_driver = {
>>  	.probe = goodix_ts_probe,
>>  	.id_table = goodix_ts_id,
>> @@ -385,6 +394,7 @@ static struct i2c_driver goodix_ts_driver = {
>>  		.name = "Goodix-TS",
>>  		.owner = THIS_MODULE,
>>  		.acpi_match_table = goodix_acpi_match,
>> +		.of_match_table = of_match_ptr(goodix_of_match),
>
> Pretty sure that wouldn't compile if CONFIG_OF is disabled.
>
>>  	},
>>  };
>>  module_i2c_driver(goodix_ts_driver);
>
>
>


-- 
Thanks and regards,
Aleksei Mamlin
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux