Re: [PATCH 2/9] iio: hid-sensor-accel-3d: Adjust parameter for attribute read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/11/2015 03:08 PM, Srinivas Pandruvada wrote:

On 01/10/2015 02:42 PM, Jonathan Cameron wrote:
On 07/01/15 18:47, Srinivas Pandruvada wrote:
The new API added a flag for sync/async mode. Added sync mode flag.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
Again, please don't break the build between patches like this.
As we did in the past, the hid sensor hub patches involving hid sensor and IIO part goes through one tree, either via IIO or HID. So once acked this needs to go through a single tree, as done in the past.
So the patches submitted in a series to avoid breaking build.

Ignore this comment.
Is this not a common procedure for API change? Single patch touching various subsystem, will be more difficult to apply.


Thanks,
Srinivas

If you want to do things in steps, you'll have to carry to versions of
the function during the conversion and drop the unwanted one at the end.

---
  drivers/iio/accel/hid-sensor-accel-3d.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/accel/hid-sensor-accel-3d.c b/drivers/iio/accel/hid-sensor-accel-3d.c
index d5d9531..0085c2f 100644
--- a/drivers/iio/accel/hid-sensor-accel-3d.c
+++ b/drivers/iio/accel/hid-sensor-accel-3d.c
@@ -130,7 +130,8 @@ static int accel_3d_read_raw(struct iio_dev *indio_dev,
              *val = sensor_hub_input_attr_get_raw_value(
                      accel_state->common_attributes.hsdev,
                      HID_USAGE_SENSOR_ACCEL_3D, address,
-                    report_id);
+                    report_id,
+                    SENSOR_HUB_SYNC);
          else {
              *val = 0;
hid_sensor_power_state(&accel_state->common_attributes,




--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux