Hi, On Tue, Jan 6, 2015 at 11:58 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi, > > On Tue, Jan 06, 2015 at 10:35:14AM +0800, Chen-Yu Tsai wrote: >> The AXP209 PMIC is used with some Allwinner SoCs. This patch adds >> a dtsi file listing all the regulator nodes. The regulators are >> initialized based on their device node names. >> >> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> >> --- >> arch/arm/boot/dts/axp209.dtsi | 87 +++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 87 insertions(+) >> create mode 100644 arch/arm/boot/dts/axp209.dtsi >> >> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi >> new file mode 100644 >> index 000000000000..3c38cbafe285 >> --- /dev/null >> +++ b/arch/arm/boot/dts/axp209.dtsi >> @@ -0,0 +1,87 @@ >> +/* >> + * Copyright 2015 Chen-Yu Tsai >> + * >> + * Chen-Yu Tsai <wens@xxxxxxxx> >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public >> + * License along with this file; if not, write to the Free >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, >> + * MA 02110-1301 USA >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/* >> + * AXP202/209 Integrated Power Management Chip >> + * http://www.x-powers.com/product/AXP20X.php >> + * http://dl.linux-sunxi.org/AXP/AXP209%20Datasheet%20v1.0_cn.pdf >> + */ >> + >> +&axp209 { >> + regulators { >> + /* Default work frequency for buck regulators */ >> + x-powers,dcdc-freq = <1500>; >> + >> + /* This section lists all the regulators */ > > I don't think this comment is necessary. > >> + reg_dcdc2: dcdc2 { >> + }; >> + >> + reg_dcdc3: dcdc3 { >> + }; >> + >> + reg_ldo1: ldo1 { >> + /* LDO1 is a fixed output regulator */ >> + regulator-always-on; >> + regulator-min-microvolt = <1300000>; >> + regulator-max-microvolt = <1300000>; >> + }; >> + >> + reg_ldo2: ldo2 { >> + }; >> + >> + reg_ldo3: ldo3 { >> + }; >> + >> + reg_ldo4: ldo4 { >> + }; >> + >> + reg_ldo5: ldo5 { >> + }; > > Some default names for the regulator would be great! Default names are already given through the regulator driver. They are full uppercase names, like in the datasheet. I could add lowercase names here for the default. ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
