Hi
On Tue, Jan 6, 2015 at 1:37 PM, Fredrik Hallenberg <megahallon@xxxxxxxxx> wrote:
> I can confirm that the patch breaks things when not using n key
> rollover. If using the Corsair K70 in "BIOS mode" or just using a
> plain USB-keyboard keys repeat forever as reported.
>
> David, I noticed that in the first version of your patch, where the
> ignore check was done in hid-core.c, you only checked events that had
> the HID_MAIN_ITEM_VARIABLE flag set. I can see that "plain" keyboards
> don't have this bit set on the release event so if I keep this check
> in the new patch it works in both cases.
>
> So, the if-clause now looks like this:
>
> ...
> if (!(field->flags & (HID_MAIN_ITEM_RELATIVE |
> HID_MAIN_ITEM_BUFFERED_BYTE)) &&
> (field->flags & HID_MAIN_ITEM_VARIABLE) &&
> usage->usage_index < field->maxusage &&
> value == field->value[usage->usage_index]) {
> ...
Nice catch! Of course, we must not apply this to ARRAY reports. I will
send v2 tomorrow (still on the road..).
Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
