On Mon, Jan 5, 2015 at 1:32 PM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > Bamboo Pads are using the generic processing but their report descriptors > differ from the ISDv* line. The pen fields are marked with the .physical > as Digitizer_Pen, which makes also sense. > > Add this field to the checks and enable for free Bamboo Pads. > > Reported-by: Josep Sanchez Ferreres <josep.sanchez.ferreres@xxxxxxxxxxxxxxx> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > --- > > Hi Jason, > > I still did not managed to put in shape the regression tests for the Wacom > recordings we have. I do not think this will impact the current supported > devices (none that I have present the HID_DG_PEN application/logical/physical > tag). > > It would be good still if you could have a look and validate the patch series. > > Cheers, > Benjamin > None of the units I've collected descriptors for appear to have a HD_DG_PEN physical collection, so I also don't see any potential for regression. For both patches: Reviewed-by: Jason Gerecke <killertofu@xxxxxxxxx> Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the two, / But you can’t take seven from three, / So you look at the sixty-fours.... > drivers/hid/wacom_wac.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/wacom_wac.h b/drivers/hid/wacom_wac.h > index 7436f2b..7afd929 100644 > --- a/drivers/hid/wacom_wac.h > +++ b/drivers/hid/wacom_wac.h > @@ -74,6 +74,7 @@ > > #define WACOM_PEN_FIELD(f) (((f)->logical == HID_DG_STYLUS) || \ > ((f)->physical == HID_DG_STYLUS) || \ > + ((f)->physical == HID_DG_PEN) || \ > ((f)->application == HID_DG_PEN)) > #define WACOM_FINGER_FIELD(f) (((f)->logical == HID_DG_FINGER) || \ > ((f)->physical == HID_DG_FINGER) || \ > -- > 2.1.0 > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
