Dudley, On Tue, Dec 09, 2014 at 07:33:03PM -0800, Jeremiah Mahler wrote: > Dudley, > > On Tue, Dec 09, 2014 at 05:11:41PM +0800, Dudley Du wrote: > > Add firmware image update function supported for gen5 trackpad device, > > it can be used through sysfs update_fw interface. > > TEST=test on Chromebooks. > > > > Signed-off-by: Dudley Du <dudley.dulixin@xxxxxxxxx> > > --- > > drivers/input/mouse/Kconfig | 2 +- > > drivers/input/mouse/cyapa_gen5.c | 290 +++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 291 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig > > index d8b46b0..63e8b40 100644 > > --- a/drivers/input/mouse/Kconfig > > +++ b/drivers/input/mouse/Kconfig > > @@ -205,7 +205,7 @@ config MOUSE_BCM5974 > > > > config MOUSE_CYAPA > > tristate "Cypress APA I2C Trackpad support" > > - depends on I2C > > + depends on I2C && CRC_ITU_T If this line is instead changed to: + depends on I2C + select CRC_ITU_T It will upgrade correctly during make oldconfig without removing MOUSE_CYAPA. And it looks like several other Kconfig files do it this way already. linux-next$ grep -r CRC_ITU_T $(find ./ -name Kconfig) > > help > > This driver adds support for Cypress All Points Addressable (APA) > > I2C Trackpads, including the ones used in 2012 Samsung Chromebooks. > > diff --git a/drivers/input/mouse/cyapa_gen5.c b/drivers/input/mouse/cyapa_gen5.c > > My initial config had MOUSE_CYAPA=m and CRC_ITU_T=n. > I did a 'make oldconfig', no questions were asked, but it removed > MOUSE_CYAPA since CRC_ITU_T wasn't enabled. Since the cyapa modules > were removed the touchpad no longer works. Not a very good upgrade path :-( > To fix this I have to manually enable MOUSE_CYAPA and CRC_ITU_T to get > it working again. > > [...] > > -- > - Jeremiah Mahler -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
