Re: [PATCH v2 2/3] HID: wacom: Initialize MT slots for generic devices at post_parse_hid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 9, 2014 at 3:00 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> On Fri, 5 Dec 2014, Benjamin Tissoires wrote:
>
>> > If a HID descriptor places HID_DG_CONTACTID before HID_DG_X and HID_DG_Y then
>> > the ABS_X and ABS_Y will not be automatically initialized by the call to
>> > input_mt_init_slots. To ensure that this is not a problem, we relocate that
>> > call to occur after HID parsing has been completed and we've initalized all
>> > the multitouch axes.
>> >
>> > Signed-off-by: Jason Gerecke <killertofu@xxxxxxxxx>
>> > ---
>>
>> This one is
>> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>
> Benjamin, does your Reviewed-by: apply to both 2/3 and 3/3?
>

Hi Jiri,

Well, I wanted to make some cosmetic changes in 3/3 and double check
that it was generic enough, but I've been sidetracked, and today I
have to keep my sick daughter.
Please apply my rev-by on this one only. Feel free to apply 3/3
however - if you can dedicate a little bit of time to check it -
(without my rev-by then), it's not that it will prevent us to change
it later if we have to.

Cheers,
Benjamin

> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux