Hi Benjamin, On Tue, Nov 18, 2014 at 5:43 AM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > Hey Antonio, > > On Nov 16 2014 or thereabouts, Antonio Borneo wrote: >> From: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx> >> >> From: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx> >> >> Current driver uses a common buffer for reading reports either >> synchronously in i2c_hid_get_raw_report() and asynchronously in >> the interrupt handler. >> There is race condition if an interrupt arrives immediately after >> the report is received in i2c_hid_get_raw_report(); the common >> buffer is modified by the interrupt handler with the new report >> and then i2c_hid_get_raw_report() proceed using wrong data. >> >> Fix it by using a separate buffers for asynchronous reports. >> >> Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@xxxxxxxxxxxxxx> >> [Antonio Borneo: cleanup and rebase to v3.17] >> Signed-off-by: Antonio Borneo <borneo.antonio@xxxxxxxxx> >> Cc: stable@xxxxxxxxxxxxxxx > > For your next submission, when you want a patch to go in stable, put CC > here, but please do not CC the actual mail to stable@. Stable should receive > either mails which are already in Linus' tree, or which refer a commit > in Linus' tree in case it does not applies smoothly. > > [keeping stable@ here to show them that this one should not get picked > right now] I agree with you to lower the noise in -stable, even if Greg does not feel annoyed. I'll take care in the future. > >> --- >> >> Hi Jiri, Benjamin, >> >> I think this patch should also go through linux-stable. >> Confirmation from our side is welcome. > > I think the patch is definitively valuable. However, my personal taste > would go for having a new .rawbuf buffer and use it in > i2c_hid_get_raw_report(). The rationale would be that it's actually > i2c_hid_get_raw_report() which is problematic, not the generic irq > handling. Also I prefer rawbuf to irqinbuf. > > I am perfectly aware that this is just bikeshedding, so if changing the > patch is too cumbersome (looks like Jean-Baptiste is involved), and if > Jiri agree, this can go into the hid tree with my reviewed-by. > > I am fine having this version or the rawbuf one in stable BTW. No major issue changing the patch in line with your suggestion; just some offline work to get also Jean-Baptiste check and approve it. I'll send shortly a V2 that adds rawbuf instead of irqinbuf. I will not add your "reviewed-by" since the code in V2 is quite different than V1. Thanks! Antonio -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
