On Fri, 31 Oct 2014, Benjamin Tissoires wrote:
> > +static int plantronics_probe(struct hid_device *hdev,
> > + const struct hid_device_id *id)
> > +{
> > + int ret;
> > +
> > + ret = hid_parse(hdev);
> > + if (ret) {
> > + hid_err(hdev, "parse failed\n");
> > + goto err;
> > + }
> > +
> > + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> > + if (ret) {
> > + hid_err(hdev, "hw start failed\n");
> > + goto err;
> > + }
> > +
> > + return 0;
> > + err:
> > + return ret;
> > +}
>
> Actually, in your case, you can even remove the probe function.
> hid-core will do open the report and start the hardware for you.
Good catch, thanks. I have removed the superfluous .probe() and applied
(with Dmitry's Reviewed-by: added to patch no .1).
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
