2014-10-31 11:00 GMT+03:00 Linus Walleij <linus.walleij@xxxxxxxxxx>: > On Tue, Oct 28, 2014 at 1:02 AM, Dmitry Eremin-Solenikov > <dbaryshkov@xxxxxxxxx> wrote: > >> LoCoMo has a possibility to generate per-GPIO edge irqs. Support for >> that was there in old locomo driver, got 'cleaned up' during old driver >> IRQ cascading cleanup and is now reimplemented. It is expected that >> SL-5500 (collie) will use locomo gpio irqs for mmc detection irq. >> >> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx> > > Please don't use open-coded IRQ handling like this, we are moving > away from that. > > In Kconfig, > > select GPIOLIB_IRQCHIP > > and look at the other drivers selecting this for inspiration. There > is even some documentation in Documentation/gpio/driver.txt > > You will find that it cuts down a lot of overhead from your driver > and does everything in the right way in a central place. Thanks, I will take a look. [Skipped the rest of the comments mostly dedicated to gpiolib_irqchip]. -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
