Hi On Wed, Oct 8, 2014 at 6:54 PM, Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> wrote: > Let's automatically set EV_ABS bit in device's event type list when calling > input_set_abs_params() so that drivers do not have to do it explicitly. > > These calls are never in a hot paths so we won't lose much time by setting > the same bit several times. Looks good to me. I mean we already do the absbit-allocation here, so this looks sane to do. Reviewed-by: David Herrmann <dh.herrmann@xxxxxxxxx> Thanks David > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> > --- > drivers/input/input.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index 29ca0bb..d2e06cc 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -498,7 +498,8 @@ void input_set_abs_params(struct input_dev *dev, unsigned int axis, > absinfo->fuzz = fuzz; > absinfo->flat = flat; > > - dev->absbit[BIT_WORD(axis)] |= BIT_MASK(axis); > + __set_bit(EV_ABS, dev->evbit); > + __set_bit(axis, dev->absbit); > } > EXPORT_SYMBOL(input_set_abs_params); > > > -- > Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
