On Thu, Sep 18, 2014 at 09:15:44AM +0200, Takashi Iwai wrote: > At Wed, 17 Sep 2014 21:23:37 +0200, > Andreas Mohr wrote: > > > > Hi, > > > > On Wed, Sep 10, 2014 at 05:57:17PM +0200, Takashi Iwai wrote: > > > The current codes in gameport and analog joystick drivers for the time > > > accounting have a long-standing problem when the system is running > > > with CPU freq; since the timing is measured via TSC or sample counter, > > > the calculation isn't reliable. > > > > Thank you very much for having followed through on this! > > (somehow you never seem to disappoint me :) > > > > While working on testing this and doing various gameport/soundcard modifications, > > I'm afraid I have seen the following checkpatch.pl (of v3.16) warnings: > > > > WARNING: Missing a blank line after declarations > > #164: FILE: drivers/input/joystick/analog.c:192: > > + unsigned int x; > > + GET_TIME(x); > > > > WARNING: line over 80 characters > > #224: FILE: drivers/input/joystick/analog.c:301: > > + port->axes[j] = (delta(start, time[i]) << ANALOG_FUZZ_BITS) / port->loop; > > Both are cosmetic and I won't be bothered if it were sent to my tree, > for example ;) It depends on the maintainer, so if Dmitry wants these > to be fixed, I'm willing to resubmit, of course. No, I do not. If there is a large rework we might want to reformat it, otherwise let's leave it as is. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
