On Thu, 11 Sep 2014, Jaewon Kim wrote:
> This patch add haptic DT binding documentation and example
> to support haptic driver in max77693 Multifunction device.
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>
> Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/mfd/max77693.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 11921cc..d178b9e 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -27,6 +27,17 @@ Optional properties:
>
> [*] refer Documentation/devicetree/bindings/regulator/regulator.txt
>
> +- haptic : The haptic of max77693 have to be instantiated under subnod
Perhaps a description as to what "The haptic" is might be handy?
s/have/has
s/subnod/subnode
What do you mean by "under" a subnode? Do you mean "as a" subnode?
> + named "haptic" using the following haptic format in example.
What is the "haptic format"? It just looks like a normal node to me.
> + Haptic sensation from motor can be changed by changing a period cycle in pwms.
Is "Haptic sensation" a technical term?
s/from motor/from a motor/
s/changed by changing/changed by varying/
s/period cycle/duty cycle/
s/in pwms/in the pwms property/
> +
> + Required properties:
> + - compatible : Must be "maxim,max77693-hpatic"
> + - haptic-supply : power supply for haptic motor
s/for haptic/for the haptic/
> + [*] refer Documentation/devicetree/bindings/regulator/regulator.txt
> + - pwms : phandle to the physical PWM device,
It's not just the phandle though is it?
> + [*] refer Documentation/devicetree/bindings/pwm/pwm.txt
> +
> Example:
> max77693@66 {
> compatible = "maxim,max77693";
> @@ -52,4 +63,11 @@ Example:
> regulator-boot-on;
> };
> };
> +
> + haptic {
> + compatible = "maxim,max77693-haptic";
> + haptic-supply = <&haptic_supply>;
> + pwms = <&pwm 0 40000 0>;
> + pwm-names = "haptic";
> + };
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
