Re: [PATCH] HID: add new gamepad LED constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

On Mon, Sep 15, 2014 at 11:57 PM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Mon, Sep 15, 2014 at 11:03:47AM -0700, Michael Wright wrote:
>> > Why not introduce all 8 player LEDs as described in the document? You
>> > should be safe increasing LED_MAX to 0x1f.
>>
>> Wasn't sure if it was safe to bump it since it could potentially break apps
>> until they recompile against the new API.
>
> I'd rather we did not add any new input LED definitions but rather
> looked into switching to LED subsystem, at least for new LEDs.

Why? The LED subsystem lacks any unprivileged API to control LEDs.
There's no cdev to control write-access to the LED API. /sys has never
been intended as unprivileged API so I'd really prefer if we add
proper input codes to control those. At least I cannot see the
advantage of the led subsystem over input EV_LED codes. Care to
elaborate?

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux