Re: [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 09/13/2014 02:26 AM, Dmitry Torokhov wrote:
> Hi Hans,
> 
> On Fri, Sep 12, 2014 at 11:08:32AM +0200, Hans de Goede wrote:
>> +/* Always check for focaltech, this is safe as it uses pnp-id matching */
>> +	if (psmouse_do_detect(focaltech_detect, psmouse, set_properties) == 0) {
>> +		if (!set_properties || focaltech_init(psmouse) == 0) {
>> +			/* Not supported yet, use bare protocol */
>> +			psmouse_max_proto = PSMOUSE_PS2;
> 
> I do not believe we need to muck with psmouse_max_proto here, so I'll
> drop it and apply.

Oh, but we do need to set psmouse_max_proto, otherwise this won't work, as
I already tried to explain in the review of v1 (but clearly failed to do so).

psmouse_initialize() checks psmouse_max_proto, and if it is not set to
PSMOUSE_PS2 does things which upsets these touchpads.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media Devel]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Linux Wireless Networking]     [Linux Omap]

  Powered by Linux