On Wed, Sep 10, 2014 at 01:07:02AM +0200, Hans de Goede wrote: > Hi, > > On 09/10/2014 12:57 AM, Dmitry Torokhov wrote: > > On Tue, Sep 09, 2014 at 03:07:21PM -0700, Andrew Duggan wrote: > >> On 09/09/2014 10:06 AM, Dmitry Torokhov wrote: > >>> On Tue, Sep 09, 2014 at 09:44:17AM +0200, Hans de Goede wrote: > >>>> Hi, > >>>> > >>>> On 09/08/2014 06:55 PM, Dmitry Torokhov wrote: > >>>>> ForcePads are found on HP EliteBook 1040 laptops. They lack any kind of > >>>>> physical buttons, instead they generate primary button click when user > >>>>> presses somewhat hard on the surface of the touchpad. Unfortunately they > >>>>> also report primary button click whenever there are 2 or more contacts > >>>>> on the pad, messing up all multi-finger gestures (2-finger scrolling, > >>>>> multi-finger tapping, etc). To cope with this behavior we introduce a > >>>>> delay (currently 50 msecs) in reporting primary press in case more > >>>>> contacts appear. > >>>>> > >>>>> For now we are using DMI matching to detect ForcePads, hopefully we'll > >>>>> be able to figure a better way down the road. > >>>> What about using the pnp-id, in my experience with the recent lenovo > >>>> laptops that tends to be more reliable. > >>> Not sure. So far I only know of HP 1040 having it. FWIW: > >>> > >>> dtor@dtor-glaptop:~$ cat /sys/bus/pnp/drivers/i8042\ aux/00\:07/id > >>> SYN300d > >>> SYN0100 > >>> SYN0002 > >>> PNP0f13 > >>> > >>> I think if we see generalities we can switch over later. I hope > >>> Chris/Andrew will come with a capability bit though :) > >> > >> The ForcePad capabilities bit is 1 << 15. > > > > Awesome, thanks! > > > > Then I guess the patch below is what we'll be needing for these devices. > > Yep, the patch looks good to me. Thanks, I'll put you down as reviewed-by then. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html